Skip to content

Make e2e work! #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 7, 2021
Merged

Make e2e work! #3

merged 4 commits into from
Feb 7, 2021

Conversation

@Sushisource
Copy link
Member

@Sushisource Sushisource commented Feb 5, 2021 •
edited
Loading

Note this requires changes in temporalio/sdk-core#41

@Sushisource Sushisource changed the title Allow using real core instance, not just mock Make e2e work! 🎉 🥳 Feb 6, 2021
@Sushisource Sushisource changed the title Make e2e work! 🎉 🥳 Make e2e work! Feb 6, 2021
bergundy
bergundy approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Exciting :)

@bergundy bergundy merged commit 6d65b61 into main Feb 7, 2021
@Sushisource Sushisource deleted the try-gluing branch February 11, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergundy bergundy bergundy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sushisource @bergundy